tFix potential underflow in item counting - sacc - sacc (saccomys): simple gopher client.

Log

Files

Refs

LICENSE

---

commit e6306449c2112574ceebe0b825bf5174157729b4

parent c56f01fe41a122aa6cc8efc59b49b7bda29b18b3

Author: Quentin Rameau 

Date:   Fri, 23 Jun 2017 20:56:47 +0200

Fix potential underflow in item counting

Diffstat:
  sacc.c                              |       6 ++++--

1 file changed, 4 insertions(+), 2 deletions(-)
---

diff --git a/sacc.c b/sacc.c

t@@ -262,9 +262,11 @@ molddiritem(char *raw)
 
         for (crlf = raw, nitems = 0; p = strstr(crlf, "\r\n"); ++nitems)
                 crlf = p+2;
-        if (--nitems < 1)
+        if (nitems <= 1)
                 return NULL;
-        if (strcmp(crlf-3, ".\r\n"))
+        if (!strcmp(crlf-3, ".\r\n"))
+                --nitems;
+        else
                 fprintf(stderr, "Parsing error: missing .\\r\\n last line\n");
 
         dir = xmalloc(sizeof(Dir));