tupas: fix warnings - plan9port - [fork] Plan 9 from user space
git clone git://src.adamsgaard.dk/plan9port
Log
Files
Refs
README
LICENSE
---
commit bae34df843174dd2dfcbb3e584ea8f963f0c1d32
parent 954e03ccfe21a06da9d581c04e92bf87feec192e
Author: David du Colombier <0intro@gmail.com>
Date:   Thu, 15 May 2014 06:28:54 +0200

upas: fix warnings

smtp.c:232: warning: comparison with string literal results in unspecified behavior
smtp.c:244: warning: comparison with string literal results in unspecified behavior
marshal.c:1179: warning: variable ‘err’ set but not used

LGTM=rsc
R=rsc
https://codereview.appspot.com/93290043

Diffstat:
  M src/cmd/upas/marshal/marshal.c      |       2 +-
  M src/cmd/upas/smtp/smtp.c            |       4 ++--

2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/cmd/upas/marshal/marshal.c b/src/cmd/upas/marshal/marshal.c
t@@ -1183,7 +1183,7 @@ waitforsubprocs(void)
                 err = w->msg;
         if(pid >= 0 && (w=procwait(pid)) && w->msg[0])
                 err = w->msg;
-        return nil;
+        return err;
 }
 
 int
diff --git a/src/cmd/upas/smtp/smtp.c b/src/cmd/upas/smtp/smtp.c
t@@ -229,7 +229,7 @@ threadmain(int argc, char **argv)
         for(i = 0; i < argc; i++){
                 if((trv = rcptto(argv[i])) != 0){
                         /* remember worst error */
-                        if(rv != Giveup)
+                        if(strcmp(rv, Giveup) != 0)
                                 rv = trv;
                         errs[rcvrs] = strdup(s_to_c(reply));
                         removenewline(errs[rcvrs]);
t@@ -241,7 +241,7 @@ threadmain(int argc, char **argv)
         }
 
         /* if no ok rcvrs or worst error is retry, give up */
-        if(ok == 0 || rv == Retry)
+        if(ok == 0 || strcmp(rv, Retry) == 0)
                 goto error;
 
         if(ping){